Bug 1781339: Ensure Spec.ProviderID is not empty string #280

michaelgugino · 2019-12-09T22:46:52Z

If the Spec.ProviderID field is present but an empty string,
we may encounter issues. This is particularly the case in
DR scenarios when a user is attempting to copy an existing
machine in attempt to create one.

If the Spec.ProviderID field is present but an empty string, we may encounter issues. This is particularly the case in DR scenarios when a user is attempting to copy an existing machine in attempt to create one.

wking · 2019-12-09T22:50:25Z

Disaster-recovery failure is being tracked in rhbz#1781339. Maybe we can have cluster-bot run that test on this PR...

Also, I'd rather guard against this by having the provider translate empty-string ProviderID to nil or having guards on input to reject empty-string values. But if that's hard for some reason, this seems like a reasonable stopgap.

wking · 2019-12-09T22:57:59Z

/retitle Bug 1781339: Ensure Spec.ProviderID is not empty string

I guess we might as well link the bug for motivation; we can always reopen the bug if it turns out this doesn't fix it.

openshift-ci-robot · 2019-12-09T22:58:03Z

@michaelgugino: This pull request references Bugzilla bug 1781339, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1781339: Ensure Spec.ProviderID is not empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-12-09T23:27:55Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T23:28:00Z

@wking: An error was encountered adding this pull request to the external tracker bugs for bug 1781339 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 100500: Insecure dependency in parameter 3 of DBI::db=HASH(0x5620f9832948)->do method call while running with -T switch at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 327.
at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 327.
Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5620f9931a00)', 1) called at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 121
Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5620fa0ac3a8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 858
Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5620fa0bfac8)', 'HASH(0x5620f9ccb198)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21
Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5620f9ccb198)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170
Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5620f9dfc608)') called at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/WebService.pm line 80
Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620f9cf1eb8)') called at (eval 2057) line 1
eval ' $procedure->{code}->($self, @params)
;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220
JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620f9869af0)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295
Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620f9869af0)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126
JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70
Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31
ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x5620f995c6f8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207
eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207
ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5620f994d0b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173
ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5620f994d0b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32
ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5620f995c6f8)') called at /var/www/html/bugzilla/mod_perl.pl line 139
Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5620f995c6f8)') called at (eval 2057) line 0
eval {...} called at (eval 2057) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino · 2019-12-10T01:31:54Z

/retest

enxebre · 2019-12-10T09:25:54Z

/retest

enxebre · 2019-12-10T09:32:36Z

can we have a unit for this?

bison · 2019-12-10T11:54:54Z

/bugzilla refresh

openshift-ci-robot · 2019-12-10T11:54:58Z

@bison: An error was encountered adding this pull request to the external tracker bugs for bug 1781339 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 100500: Insecure dependency in parameter 3 of DBI::db=HASH(0x5620fb21d940)->do method call while running with -T switch at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 327.
at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 327.
Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5620fb245de0)', 1) called at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 121
Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5620fab61ba8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 858
Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5620f9f6e8d8)', 'HASH(0x5620f98b6c58)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21
Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5620f98b6c58)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170
Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5620f9dfbfb8)') called at /loader/0x5620f51258a8/Bugzilla/Extension/ExternalBugs/WebService.pm line 80
Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620fb226cf8)') called at (eval 2691) line 1
eval ' $procedure->{code}->($self, @params)
;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220
JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620f9f69a18)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295
Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5620f9f69a18)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126
JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70
Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31
ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x5620f9c61f60)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207
eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207
ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5620f9d1a440)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173
ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5620f9d1a440)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32
ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5620f9c61f60)') called at /var/www/html/bugzilla/mod_perl.pl line 139
Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5620f9c61f60)') called at (eval 2691) line 0
eval {...} called at (eval 2691) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-12-10T17:25:51Z

e2e-aws:

level=error msg="Cluster operator machine-config Degraded is True with RequiredPoolsFailed: Failed to resync 0.0.1-2019-12-10-092928 because: timed out waiting for the condition during syncRequiredMachineConfigPools: pool master has not progressed to latest configuration: configuration status for pool master is empty: pool is degraded because nodes fail with \"3 nodes are reporting degraded status on sync\": \"Node ip-10-0-143-107.ec2.internal is reporting: \\\"unexpected on-disk state validating against rendered-master-e3381e0f926333dc88ba745c8bf92156\\\", Node ip-10-0-132-249.ec2.internal is reporting: \\\"unexpected on-disk state validating against rendered-master-e3381e0f926333dc88ba745c8bf92156\\\", Node ip-10-0-149-95.ec2.internal is reporting: \\\"machineconfig.machineconfiguration.openshift.io \\\\\\\"rendered-master-e3381e0f926333dc88ba745c8bf92156\\\\\\\" not found\\\"\", retrying"

Which is rhbz#1781708.

wking · 2019-12-11T03:43:06Z

/Bugzilla refresh

openshift-ci-robot · 2019-12-11T03:43:10Z

@wking: This pull request references Bugzilla bug 1781339, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/Bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-12-11T03:43:28Z

/bugzilla refresh

openshift-ci-robot · 2019-12-11T03:43:31Z

@wking: This pull request references Bugzilla bug 1781339, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2019-12-11T08:34:08Z

/retest

bison

/lgtm

enxebre · 2019-12-11T10:44:06Z

I'd wish #280 (comment)
have been addressed in this PR nevertheless we need to keep moving
/approve

openshift-ci-robot · 2019-12-11T10:44:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2019-12-11T10:48:31Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2019-12-11T10:48:32Z

@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-12-11T12:20:52Z

@michaelgugino: All pull requests linked via external trackers have merged. Bugzilla bug 1781339 has been moved to the MODIFIED state.

In response to this:

Bug 1781339: Ensure Spec.ProviderID is not empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-12-11T12:21:05Z

@enxebre: new pull request created: #281

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2019

openshift-ci-robot requested review from bison and frobware December 9, 2019 22:47

Ensure Spec.ProviderID is not empty string

3d1e2c6

If the Spec.ProviderID field is present but an empty string, we may encounter issues. This is particularly the case in DR scenarios when a user is attempting to copy an existing machine in attempt to create one.

michaelgugino force-pushed the check-empty-quote-providerspec branch from ac1f1c4 to 3d1e2c6 Compare December 9, 2019 22:49

openshift-ci-robot changed the title ~~Ensure Spec.ProviderID is not empty string~~ Bug 1781339: Ensure Spec.ProviderID is not empty string Dec 9, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 11, 2019

bison approved these changes Dec 11, 2019

View reviewed changes

openshift-ci-robot assigned bison Dec 11, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019

openshift-merge-robot merged commit 07a8fd7 into openshift:master Dec 11, 2019

openshift-cherrypick-robot mentioned this pull request Dec 11, 2019

[release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string #281

Merged

enxebre mentioned this pull request Feb 11, 2020

Bug 1796595: [release-4.2] Mitigate aws eventual consistency issues #295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1781339: Ensure Spec.ProviderID is not empty string #280

Bug 1781339: Ensure Spec.ProviderID is not empty string #280

michaelgugino commented Dec 9, 2019

wking commented Dec 9, 2019

wking commented Dec 9, 2019

openshift-ci-robot commented Dec 9, 2019

wking commented Dec 9, 2019

openshift-ci-robot commented Dec 9, 2019

michaelgugino commented Dec 10, 2019

enxebre commented Dec 10, 2019

enxebre commented Dec 10, 2019

bison commented Dec 10, 2019

openshift-ci-robot commented Dec 10, 2019

wking commented Dec 10, 2019

wking commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

wking commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

enxebre commented Dec 11, 2019

bison left a comment

enxebre commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

enxebre commented Dec 11, 2019

openshift-cherrypick-robot commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

openshift-cherrypick-robot commented Dec 11, 2019

Bug 1781339: Ensure Spec.ProviderID is not empty string #280

Bug 1781339: Ensure Spec.ProviderID is not empty string #280

Conversation

michaelgugino commented Dec 9, 2019

wking commented Dec 9, 2019

wking commented Dec 9, 2019

openshift-ci-robot commented Dec 9, 2019

wking commented Dec 9, 2019

openshift-ci-robot commented Dec 9, 2019

michaelgugino commented Dec 10, 2019

enxebre commented Dec 10, 2019

enxebre commented Dec 10, 2019

bison commented Dec 10, 2019

openshift-ci-robot commented Dec 10, 2019

wking commented Dec 10, 2019

wking commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

wking commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

enxebre commented Dec 11, 2019

bison left a comment

Choose a reason for hiding this comment

enxebre commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

enxebre commented Dec 11, 2019

openshift-cherrypick-robot commented Dec 11, 2019

openshift-ci-robot commented Dec 11, 2019

openshift-cherrypick-robot commented Dec 11, 2019